search

FDM-UARuhr / rdmo-catalog-uaruhr

Host of RDMO catalogs developed by FDM-UARuhr.
https://fdm-uaruhr.github.io/rdmo-catalog-uaruhr/
Creative Commons Zero v1.0 Universal
2 stars 4 forks source link

Attributes used twice in UA Ruhr catalog #74

Closed ClaraRosalie closed 2 years ago

ClaraRosalie commented 3 years ago

I found two attributes which appear twice in https://rdmo-demo.rd.ruhr-uni-bochum.de/questions/catalogs/7/:

  1. The attribute https://rdmorganiser.github.io/terms/domain/project/legal_aspects/official_approval/data_access_committee is used for two different questions:

    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/data-usage/data-sharing-and-re-use-publication/restricted_access / If there are restrictions on making the data openly accessible, how will restricted access be provided?
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/legal-and-ethics/sensitive-data-official_approval/data_access_committee / Is a data access committee needed to handle access requests to the published data of the project?

  2. The attribute https://rdmorganiser.github.io/terms/domain/project/coordination/name appears twice each with the same question but different question path variable:

    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/general/topic-research_field/name / Which persons or institutions are responsible for the project coordination?
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/general/project-partners-name/name / Which persons or institutions are responsible for the project coordination?
jmfrenzel commented 3 years ago

I cannot reproduce 1. on that server and also not in the files rdmorganiser/questions/ua_ruhr.xml and tools/all_questions.xml

  1. The attribute https://rdmorganiser.github.io/terms/domain/project/legal_aspects/official_approval/data_access_committee is used for onetwo different questions:
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/data-usage/data-sharing-and-re-use-publication/restricted_access / If there are restrictions on making the data openly accessible, how will restricted access be provided?
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/legal-and-ethics/sensitive-data-official_approval/data_access_committee / Is a data access committee needed to handle access requests to the published data of the project?
jmfrenzel commented 3 years ago

I can reproduce in the files rdmorganiser/questions/ua_ruhr.xml and tools/all_questions.xml , that

  1. The attribute https://rdmorganiser.github.io/terms/domain/project/coordination/name appears twice each with the same question but different question path variable:
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/general/topic-research_field/name / Which persons or institutions are responsible for the project coordination?
    • https://rdmorganiser.github.io/terms/questions/ua_ruhr/general/project-partners-name/name / Which persons or institutions are responsible for the project coordination?

The latter

  • https://rdmorganiser.github.io/terms/questions/ua_ruhr/general/project-partners-name/name / Which persons or institutions are responsible for the project coordination?

should be the correct (and only) question referencing that attribute see the file rdmorganiser/questions/ua_ruhr.xml and tools/all_questions.xml which is in sync with upstream.

ClaraRosalie commented 3 years ago

I can still reproduce 1. on rdmo-demo - the same attribute is used for two different question path variables and questions.

jmfrenzel commented 3 years ago

https://github.com/rdmorganiser/rdmo-catalog/pull/20