search

FDOS / freecom

FreeDOS Command Shell (command.com)
http://www.freedos.org/
GNU General Public License v2.0
155 stars 38 forks source link

Translations #38

Closed andrewbird closed 3 years ago

andrewbird commented 3 years ago

1/ I've done a slightly different version of the .gitattributes change I proposed earlier, that is with no renaming just better diffing. This has generated a large initial diff for each language on github, but that's just an illusion from the encoding change if you checkout you'll see there's no change. 2/ I found the problem with the remaining translations triggering the segfault in fixstrs, some translations were empty strings. I've added some label 'Missing' to those so that perhaps people with the right skils will update with the proper wording. 3/ I enabled the remaining translations in the CI_build. 4/ And finally I noticed that yu852.lng and serbian.lng are identical, can we delete one as it seems silly to maintain both?

PerditionC commented 3 years ago

I don't see a need for identical files. To be consistent I think the yu852 is the one to remove. This looks good to me, is it ready to be merged?

andrewbird commented 3 years ago

I added a prior commit to remove the 'yu852' translation and amended the others accordingly. Yes it should be good to merge now, thanks.

andrewbird commented 3 years ago

Incidentally I just found this https://sourceforge.net/projects/utf8tocp/ which may prove useful if you wish to change the repo to store translations in utf-8 and convert to the required codepage at build time in the future.