search

FDio / govpp

Go toolset for the VPP.
Apache License 2.0
193 stars 82 forks source link

Fix for Dockerfile smell DL3008 #123

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "test/build/Dockerfile.integration" contains the best practice violation DL3008 detected by the hadolint tool.

The smell DL3008 occurs when the version pinning for the installed packages with apt is not specified. This could lead to unexpected behavior when building the Dockerfile. In this pull request, we propose a fix for that smell generated by our fixing tool. We have verified that the patch is correct before opening the pull request. To fix this smell, specifically, we use a heuristic approach that selects the most probable version tag for a given apt package corresponding to the latest version at the current date. The package versions are retrieved from the Canonical Launchpad APIs.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

ondrej-fabry commented 1 year ago

It seems the version specified for the ca-certificates package has been removed and is no longer available, which causes builds to fail.