linter: fixes for staticcheck

sknat commented 2 years ago

As golint is now deprecated, this patch proposes to switch to staticcheck [0] as an alternative, in addition to go vet. This patch contains fixes addressing the linter's reported issues, with two added exceptions :

The MemoryStats deprectated fields are still for us to update
In gen_encoding.go we need to add an extra comment to account for the unused variable. This is probably worth addressing in another patch to not generate a variable we don't use.

[0] https://staticcheck.io/

Signed-off-by: Nathan Skrzypczak nathan.skrzypczak@gmail.com Change-Id: I0562f290fb908bc610c44d675e21e466d0badc27

ondrej-fabry commented 2 years ago

It seems pointless to add special comments to the generated files. The tool should ignore the generated files entirely.

sknat commented 2 years ago

Removed the changes in the generated code for now & updated the patch

FDio / govpp

linter: fixes for staticcheck #27