FDio / govpp

Go toolset for the VPP.
Apache License 2.0
193 stars 82 forks source link

Run more steps in CI #49

Closed ondrej-fabry closed 1 year ago

ondrej-fabry commented 1 year ago

To improve the quality of the code that is merged to master, the CI pipeline should perform more tests or checks for common things developers forget to update.

dwallacelf commented 1 year ago

Do we need a docs verification task?

I was able to review PR#70 by going to the 'Files Changed' tab and selecting '...'/'View file' for docs/troubleshooting.md which showed that the markdown rendered correctly.

However, if the syntax was incorrect, does anything in the CI run *.md files through the github renderer and mark it as not mergeable?

As an optimization, it would be good to skip the build verification tasks for docs only PR's, but may not be worth implementing if it make the CI too complex.

ondrej-fabry commented 1 year ago

All tasks complete as part of release v0.7.0. For the rest separate issues were created for tracking them.