search

FDio / govpp

Go toolset for the VPP.
Apache License 2.0
193 stars 82 forks source link

Added a doc.go to binapi/ to ensure it always has a package. #56

Closed edwarnicke closed 1 year ago

edwarnicke commented 1 year ago

Signed-off-by: Ed Warnicke hagbard@gmail.com

ondrej-fabry commented 1 year ago

When does this problem occur?

I think it'd be best to keep the number of generated files to minimum. Having a single generated file for Go bindings (.ba.go) per each VPP API file (.api.json) is ideal. All changes for package happen in one file, which can easily be copy-pasted, moved, diffed.. etc in a single straight-forward step. Any more than one file means we practically double the amount of files and info can possibly be out of sync, because they always have to change, move, create or delete together.

These kind of applies to #21 as well.

ondrej-fabry commented 1 year ago

As part of cleaning up open items before the release, I am closing this PR as there was no response from the author for some time.