search

FEC-corgis / Jenny-Service-Reviews

Airbnb-styled service-oriented architecture app that generates, persists, and displays product data. Built with MERN, React Styled Components, & React Router DOM.
1 stars 0 forks source link

Added db schemas and seed file. #1

Closed jhou12 closed 3 years ago

jhou12 commented 3 years ago

@manedurphy @pauly-van @slava000

If you need to get a code review done, can you guys take a look at my seeding script for the Reviews module and lmk if it's good to go? I went over it briefly with Alex in OH and he said the process looks good, and it seems to function as it's supposed to, just want to make sure the code is clear and well-organized. Thanks.

jhou12 commented 3 years ago

@manedurphy @pauly-van @slava000

Also separate code review if you want but can you look at my fakeData.js functions and lmk if anything is unclear, they are also used in my seeding script. Thanks!

manedurphy commented 3 years ago

I noticed in the seed script for reviews that you averaged all categories to calculate the overall average, but I think I remember in class we said that the overall rating was separate from the individual category ratings.

jhou12 commented 3 years ago

@manedurphy Yes I was a bit confused about what we heard in class too, but I went back and calculated averages for a few more properties and found that they did correlate to the overall average, so I used that. Lmk if you think there's a better way to find the overall score, I'd be happy to modify the calculation. Thanks for the note!

jhou12 commented 3 years ago

@manedurphy Just made a commit and changed the overall score to be generated randomly like the other 6 metrics instead of calculated as an average, thanks for the tip!