search

FEISystems / ca-adpq-prototype

CA ADPQ
2 stars 2 forks source link

Issue #115 - Search/Edit/Delete Items in a Catalog functionality is NOT working #154

Closed neelusingh28 closed 7 years ago

neelusingh28 commented 7 years ago

User: Admin1

lutech commented 7 years ago

User: Admin1

lutech commented 7 years ago

@davidatfei @ClaireReinken I was able to resolve some of the issues but the 2 below would require back end work. Not sure if they're exactly necessary however. As they're in the requirements in #115, I will let Claire decide if these are truly necessary. @ClaireReinken , can you please confirm?

ClaireReinken commented 7 years ago
  1. Product Image - Browse for image - is not available on the search page
  2. User does not have an option to delete multiple items These are nice to have at this point. Let's remove them from the acceptance criteria. I will move this issue to QC Doing.
davidatfei commented 7 years ago

I added the ability to delete multiple items. I also added the image file name box to the search page. I don’t know if that is what was intended by #4, but that’s what I did.

I could not get a checkbox to display, so I just use s with text that toggles between Selected and Unselected. UI people, feel free to change that.

One of the reports (Trend I think) says to initially select the current Fiscal Quarter date range. I need the rules you want me to use for determining the fiscal quarter based on a calendar date.

From: ClaireReinken [mailto:notifications@github.com] Sent: Sunday, February 26, 2017 2:25 PM To: FEISystems/ca-adpq-prototype ca-adpq-prototype@noreply.github.com Cc: David Lorek David.Lorek@feisystems.com; Assign assign@noreply.github.com Subject: Re: [FEISystems/ca-adpq-prototype] Issue #115 - Search/Edit/Delete Items in a Catalog functionality is NOT working (#154)

  1. Product Image - Browse for image - is not available on the search page
  2. User does not have an option to delete multiple items These are nice to have at this point. Let's remove them from the acceptance criteria. I will move this issue to QC Doing.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282579994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYjdn1JqIzjiaYiOe3vxHfzc4dUu8zHmks5rgdGkgaJpZM4MLuU_.

ClaireReinken commented 7 years ago

Let's make the fiscal quarter a calendar quarter.

FY Q1 = Jan - march FY Q2= April - June FY Q3 = July - Sept FY Q4 = Oct - Dec

On Feb 26, 2017, at 4:55 PM, davidatfei notifications@github.com<mailto:notifications@github.com> wrote:

I added the ability to delete multiple items. I also added the image file name box to the search page. I don't know if that is what was intended by #4, but that's what I did.

I could not get a checkbox to display, so I just use s with text that toggles between Selected and Unselected. UI people, feel free to change that.

One of the reports (Trend I think) says to initially select the current Fiscal Quarter date range. I need the rules you want me to use for determining the fiscal quarter based on a calendar date.

From: ClaireReinken [mailto:notifications@github.com] Sent: Sunday, February 26, 2017 2:25 PM To: FEISystems/ca-adpq-prototype ca-adpq-prototype@noreply.github.com<mailto:ca-adpq-prototype@noreply.github.com> Cc: David Lorek David.Lorek@feisystems.com<mailto:David.Lorek@feisystems.com>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [FEISystems/ca-adpq-prototype] Issue #115 - Search/Edit/Delete Items in a Catalog functionality is NOT working (#154)

  1. Product Image - Browse for image - is not available on the search page
  2. User does not have an option to delete multiple items These are nice to have at this point. Let's remove them from the acceptance criteria. I will move this issue to QC Doing.

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282579994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYjdn1JqIzjiaYiOe3vxHfzc4dUu8zHmks5rgdGkgaJpZM4MLuU_.

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282591138, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVkcDKdGfJHqt6L9IT-6WEGqw5m0Pahuks5rgfThgaJpZM4MLuU_.

llin-freeman commented 7 years ago

Hi, I thought we were using a date range, so the user selects start & end date for the desired report. That reduces the risk of calendar vs fiscal year issues.

Thanks

Get Outlook for iOShttps://aka.ms/o0ukef

On Sun, Feb 26, 2017 at 4:59 PM -0500, "ClaireReinken" notifications@github.com<mailto:notifications@github.com> wrote:

Let's make the fiscal quarter a calendar quarter.

FY Q1 = Jan - march FY Q2= April - June FY Q3 = July - Sept FY Q4 = Oct - Dec

On Feb 26, 2017, at 4:55 PM, davidatfei notifications@github.com<mailto:notifications@github.com> wrote:

I added the ability to delete multiple items. I also added the image file name box to the search page. I don't know if that is what was intended by #4, but that's what I did.

I could not get a checkbox to display, so I just use s with text that toggles between Selected and Unselected. UI people, feel free to change that.

One of the reports (Trend I think) says to initially select the current Fiscal Quarter date range. I need the rules you want me to use for determining the fiscal quarter based on a calendar date.

From: ClaireReinken [mailto:notifications@github.com] Sent: Sunday, February 26, 2017 2:25 PM To: FEISystems/ca-adpq-prototype ca-adpq-prototype@noreply.github.com<mailto:ca-adpq-prototype@noreply.github.com> Cc: David Lorek David.Lorek@feisystems.com<mailto:David.Lorek@feisystems.com>; Assign assign@noreply.github.com<mailto:assign@noreply.github.com> Subject: Re: [FEISystems/ca-adpq-prototype] Issue #115 - Search/Edit/Delete Items in a Catalog functionality is NOT working (#154)

  1. Product Image - Browse for image - is not available on the search page
  2. User does not have an option to delete multiple items These are nice to have at this point. Let's remove them from the acceptance criteria. I will move this issue to QC Doing.

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282579994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYjdn1JqIzjiaYiOe3vxHfzc4dUu8zHmks5rgdGkgaJpZM4MLuU_.

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282591138, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVkcDKdGfJHqt6L9IT-6WEGqw5m0Pahuks5rgfThgaJpZM4MLuU_.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/FEISystems/ca-adpq-prototype/issues/154#issuecomment-282591455, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVdwwzu_h9OLi0IFW1dRfGXxM2eggjL0ks5rgfXXgaJpZM4MLuU_.

neelusingh28 commented 7 years ago

User: Admin1

Above issues are fixed but found following issues now.

  1. Pagination issue - Search always displays Page # of 44 even though there are less products available.

  2. Image appears only if user hits on edit button and then comes back on left menu search. After that clear search button does not clear image.

  3. Inventory display issue - Dell is 248 but search bringing only 10 results, Services are 99 in data set but displaying only 90

  4. Contract Expiration field does NOT bring any results. Tried 6/10/2017 & 6-10-2017

  5. Search>Edit - I think there should be 'Cancel' button if in case user does not want to save and comes out of that screen.

  6. Should we expand cells width when text is larger? Please check screenshot

image

davidatfei commented 7 years ago
  1. Fixed
  2. Fixed
  3. Cannot duplicate
  4. Try yyyy-mm-dd. Maybe the UI people can change this to a date picker.
  5. Added Cancel button. Changes to styling are causing the placement to be weird. UI people should address.
  6. Question for UI people.
jennymnh commented 7 years ago

@christianhfei will take a look, thanks.

christianhfei commented 7 years ago

Checkbox issue is resolved, the USA stylesheet's custom checkbox styles were hiding the real checkbox, so I just removed them. This will only apply to the checkboxes inside tables in the admin catalog section.

https://github.com/FEISystems/ca-adpq-prototype/commit/9a4cf4e9f4ee8a2ef0ec3c49edb8af1f7e005ad8

neelusingh28 commented 7 years ago

All above issues are fixed but found following issues now.

  1. After search results if clicked on browser back arrow, system takes the user to the Admin home page instead of search page.
  2. Edit Product - if Product does not have UNSPSC then system is forcing user to enter that until that 'Save' button does not get activated.
  3. Save changes button not saving changes. generating error.
  4. Delete link deleting item but displaying error.

image

davidatfei commented 7 years ago
  1. When on the reports page, Back is the Admin home page.
  2. It is being treated as a required column. If you have requirements that say otherwise, please provide.
  3. Cannot duplicate. Try to login as an admin.
  4. Cannot duplicate. Try to login as an admin.

If you are encountering the unauthorized operation errors after signing in as an admin, please write down detailed steps to reproduce the problem.

neelusingh28 commented 7 years ago

Verified and Passed in 5000 site and working as expected in Chrome & Firefox.