search

FENRlR / MB-iSTFT-VITS2

Application of MB-iSTFT-VITS components to vits2_pytorch
MIT License
107 stars 27 forks source link

Boolean value subbands in istft_vits2_base.json? #14

Closed isdanni closed 10 months ago

isdanni commented 10 months ago

https://github.com/FENRlR/MB-iSTFT-VITS2/blob/17593f65ae3cfa99fa584c1e4e1d5723e2a4d97d/configs/istft_vits2_base.json#L51 vs

https://github.com/FENRlR/MB-iSTFT-VITS2/blob/17593f65ae3cfa99fa584c1e4e1d5723e2a4d97d/pqmf.py#L56

Was wondering if this is accurate? I usually see people set it to values like 4 or 8

FENRlR commented 10 months ago

It was the original MB-iSTFT-VITS repository which set it to the boolean type, but that does not really matter because the istft generator does not use subbands, nor the pqmf. They are for the mb and ms variants.

isdanni commented 10 months ago

Thanks for your explanation!