search

FERNman / angular-google-charts

A wrapper for the Google Charts library written in Angular.
Other
276 stars 107 forks source link

Locale Support #295

Closed cheesgno closed 2 months ago

cheesgno commented 1 year ago

Hi! As defined in the google documentation

// Load Google Charts for the Japanese locale. google.charts.load('current', {'packages':['corechart'], 'language': 'ja'});

is there a way to load a graph with a specific locale and change it dinamically?

Best Regards

GertrudMathilde commented 1 year ago

Is there any chance for this to be implemented? The project seems pretty dead :( While I can use workarounds to use this package with angular 16, I can't make the locale work...

FERNman commented 2 months ago

Would be open to accepting PRs implementing this feature! If I have some time in the upcoming days, I'll maybe look into it.

FERNman commented 2 months ago

Okay, as promised: I looked into it. This is implemented in a specific way: The ScriptLoaderService loads the language provided by LOCALE_ID.

If this should be reworked, I'd be very open to reopening this issue and accepting PRs (I'll rework the module to support standalone components in the upcoming releases, this might cause me to look at the DI anyways).