search

FERNman / angular-google-charts

A wrapper for the Google Charts library written in Angular.
Other
276 stars 107 forks source link

Angular 15 #296

Closed oobayly closed 2 months ago

oobayly commented 1 year ago

When I created #278 I [stupidly] targeted Angular 14, which has meant that the package can't be used with Angular 13 - something that's just bitten me in the a**. Also noted in #282

This PR reverts the build version to Angular 12 (v.2.2.2), but updates the peer dependencies to <=15.x (#292)

~Initially, I want to check that this builds correctly on CircleCI~ CircleCI passes now, and I appreciate that releasing a package version that targets a lower Angular version may be problematic.

My next task is to try using this in an angular app starting with 12 to make sure I haven't screwed anything up.

I've also included the following:

CarnsJalone commented 1 year ago

Bumping this thread. Is there any momentum to have this pull request reviewed and merged.

mlangwell commented 1 year ago

We could really use this PR merged for our team. It is preventing us from completing our update to Angular 15 since we use this package.

lazybobcat commented 1 year ago

same here, this is the last package preventing us from updating to Angular 15

oobayly commented 1 year ago

For those of you feeling brave, I've attached a zip file of the tarball (GitHub does't support attaching tarballs), from which you can do a local install. This is what I've done with my current project as I really don't want to have to publish an NPM package.

angular-google-charts-2.2.3.tgz.zip

HenriqueEichstadt commented 1 year ago

Is there a deadline for approving this pull request?

funat commented 1 year ago

Same question here - this library is th only one blocking us to move the project to Angular 15.

CristoferEichstadt commented 1 year ago

Is there a deadline for approving this pull request?

mohamed-badaoui commented 1 year ago

update to peer dependencies to 16.x ?

diegoberges commented 1 year ago

Approves the PR, please.

sgovorov commented 7 months ago

Is there a possibility to update dependencies to 16.x?

mohamed-badaoui commented 7 months ago

Is there a possibility to update dependencies to 17.x?

maurodam commented 6 months ago

Why doesn't anyone maintain this project anymore and approve pull requests? If this library is no longer maintained, can't you manage to duplicate, create a new package and take over for future updates? Citing the creator of course