FESOM / fesom2

Multi-resolution ocean general circulation model.
http://fesom.de/
GNU General Public License v3.0
47 stars 48 forks source link

Add Discret Variance Decay (DVD) diagnostic of Knut and Sergey #578

Closed patrickscholz closed 1 month ago

patrickscholz commented 6 months ago

grafik

JanStreffing commented 3 months ago
Variable: a_ice, current_value: 0.26924984548439423, master_value: 0.2692498167543513
FAIL!!!: a_ice DIFFERENCE: 2.873004295578241e-08.

Variable: salt, current_value: 23.944089812825084, master_value: 23.94408981205545
FAIL!!!: salt DIFFERENCE: 7.696350223795889e-10.

Variable: sst, current_value: 8.52679144278934, master_value: 8.526792796340805
FAIL!!!: sst DIFFERENCE: -1.3535514646889624e-06.

Variable: temp, current_value: 1.701819029858262, master_value: 1.7018189804276316
FAIL!!!: temp DIFFERENCE: 4.943063047768703e-08.

Variable: u, current_value: -0.0014310721311603398, master_value: -0.0014310701355284
FAIL!!!: u DIFFERENCE: -1.995631939864448e-09.

Variable: v, current_value: 0.00014314162989162503, master_value: 0.0001431423767448
FAIL!!!: v DIFFERENCE: -7.468531749803536e-10.
JanStreffing commented 2 months ago

Here is the tripyview evaluation of a 1958 to 2017 standalone run with DVD diagnost vs the same period with the current main branch. I have nowhere to host the html, so as a pdf instead: fesom26rc_addDVDsergeyandknut.pdf

JanStreffing commented 2 months ago

Changes are numerical in nature only, and I approve the PR. However, merge conflict resolution is not trivial. I leave this to you @patrickscholz