Closed patrickscholz closed 1 month ago
Variable: a_ice, current_value: 0.26924984548439423, master_value: 0.2692498167543513
FAIL!!!: a_ice DIFFERENCE: 2.873004295578241e-08.
Variable: salt, current_value: 23.944089812825084, master_value: 23.94408981205545
FAIL!!!: salt DIFFERENCE: 7.696350223795889e-10.
Variable: sst, current_value: 8.52679144278934, master_value: 8.526792796340805
FAIL!!!: sst DIFFERENCE: -1.3535514646889624e-06.
Variable: temp, current_value: 1.701819029858262, master_value: 1.7018189804276316
FAIL!!!: temp DIFFERENCE: 4.943063047768703e-08.
Variable: u, current_value: -0.0014310721311603398, master_value: -0.0014310701355284
FAIL!!!: u DIFFERENCE: -1.995631939864448e-09.
Variable: v, current_value: 0.00014314162989162503, master_value: 0.0001431423767448
FAIL!!!: v DIFFERENCE: -7.468531749803536e-10.
Here is the tripyview evaluation of a 1958 to 2017 standalone run with DVD diagnost vs the same period with the current main branch. I have nowhere to host the html, so as a pdf instead: fesom26rc_addDVDsergeyandknut.pdf
Changes are numerical in nature only, and I approve the PR. However, merge conflict resolution is not trivial. I leave this to you @patrickscholz
Introduce new diagnostic flag in namelsit.io: ldiag_DVD
Add DVD diagnostic of Knut Klingbeil et al. 2014, Quantification of spurious dissipation and mixing – Discrete Variance Decay in a Finite-Volume framework. For Knuts diagnostic we are not able to split up the DVD in its singular component. There we are only able to quantify a total DVD, considering all effects that manipulates the tracer.
Add DVD diagnostic of Sergey Danilov after T. Banerjee et al. 2023, Discrete variance decay analysis of spurious mixing. In this diagnostic we are able to split up the DVD contributions in all of its components.
This commit already considers the changes made in Pull Request: Refactoring bugfix: fix three small bugs in the tracer part #575. Since these changes had to be taken into account in the computation of DVD. So it would make sense to merge this to refactoring after #575 has been merged. --> that also means that in moment the testcase will fail!
It also includes the path updates from ollie-->albedo for namelist.config and namelist.forcing