search

FESOM / pyfesom2

FESOM2 tools https://pyfesom2.readthedocs.io
MIT License
15 stars 10 forks source link

`faces` in xarray accessor exclude cyclic elements #136

Open koldunovn opened 3 years ago

koldunovn commented 3 years ago

Currently faces in xarray accessor - exclude cyclic elements. It's good for plotting, but not so nice for data analysis. We have to discuss what to keep. I would rather go for excluding cyclic elements during plotting itself, not to hide this info from the user.

koldunovn commented 3 years ago

Here is an example of a function that use all nodes: https://github.com/FESOM/pyfesom2/blob/a2951ced1ead4e02ad015a62d6f7b8512b2c5bb2/pyfesom2/regridding.py#L661

Anyway by cutting down the elements we don't provide the complete data to the user. I think whether or not cyclic points should be excluded should be decided on (plotting) function level, not at the dataset level.

suvarchal commented 3 years ago

it is fixed in #134 , but more work to go in that PR.