FEniCS / dolfinx

Next generation FEniCS problem solving environment
https://fenicsproject.org
GNU Lesser General Public License v3.0
761 stars 182 forks source link

eps2 constants too small? #2412

Open jhale opened 2 years ago

jhale commented 2 years ago

@garth-wells raised the issue about the size of the eps2 constant which is used in various geometry kernels as a tolerance.

https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/geometry/utils.cpp#L482

Are they too small?

nate-sime commented 2 years ago

If there's no significant performance hit it would be helpful for the user to be able to define all geometric tolerances. It's particularly frustrating for meshes with diverse length scales.