search

FEniCS / dolfinx

Next generation FEniCS problem solving environment
https://fenicsproject.org
GNU Lesser General Public License v3.0
734 stars 178 forks source link

Commented terms in hyperelasticity demo #2584

Closed mscroggs closed 5 months ago

mscroggs commented 1 year ago

In the hyperelasticity demo, there are terms that have been commented out:

https://github.com/FEniCS/dolfinx/blob/dfee3c4449625a1141650e3c678487627a6a01b9/cpp/demo/hyperelasticity/hyperelasticity.py#L32-L33

https://github.com/FEniCS/dolfinx/blob/dfee3c4449625a1141650e3c678487627a6a01b9/cpp/demo/hyperelasticity/hyperelasticity.py#L65

These should either be uncommented or removed

ghost commented 1 year ago

Sir this is actually my first pr and I don't know what happened since it already showed closed to me. It would'be really helpful if anyone can help

IgorBaratta commented 1 year ago

Sir this is actually my first pr and I don't know what happened since it already showed closed to me. It would'be really helpful if anyone can help

I think you've deleted the branch, fix/Commented-terms-in-HyperelastcityDemo, you used to create the PR. So github closed it automatically.