search

FEniCS / dolfinx

Next generation FEniCS problem solving environment
https://fenicsproject.org
GNU Lesser General Public License v3.0
779 stars 181 forks source link

Revise method name `MatrixCSR::finalize` #2710

Closed garth-wells closed 1 year ago

garth-wells commented 1 year ago

The above method name is misleading. After a call to 'finalize', matrix entries can still be changed. The method performs a reverse scatter.

Now that we're using MatrixCSR more in demos, we should fix the name before the next release.

chrisrichardson commented 1 year ago

assemble is also bad. We could use scatter_reverse to match Vector. Or gather_rows perhaps?

garth-wells commented 1 year ago

assemble is widely used - PETSc and Tpetra use it.

chrisrichardson commented 1 year ago

I think Tpetra uses fillComplete

IgorBaratta commented 1 year ago

I think it should have a name that clearly indicates that it's performing some communication. assemble or fillComplete don't convey this meaning for me.

jhale commented 1 year ago

Reconcile?

chrisrichardson commented 1 year ago

Reconcile?

Yes, but how?

chrisrichardson commented 1 year ago

See https://github.com/FEniCS/dolfinx/pull/2732.