search

FEniCS / dolfinx

Next generation FEniCS problem solving environment
https://fenicsproject.org
GNU Lesser General Public License v3.0
734 stars 178 forks source link

Add support for cell-wise data in ADIOS2 output #2720

Closed massimiliano-leoni closed 5 months ago

massimiliano-leoni commented 1 year ago

Describe new/missing feature

In the current source code we throw an error complaining that VTK does not support cell data

https://github.com/FEniCS/dolfinx/blob/e561c6cdbb3712d73e42699044acc5ed6ac43c0b/cpp/dolfinx/io/ADIOS2Writers.h#L898-L905

which used to be true. However, a few months ago this changed as the Merge Request https://gitlab.kitware.com/vtk/vtk/-/merge_requests/7401 in VTK was accepted.

At this point we should implement the missing functionality.

Suggestion user interface

No response

jorgensd commented 1 year ago

It is not yet in a released version of Paraview (as far as Im aware). However, i agree that once there is a binary with the support we should implement this.

massimiliano-leoni commented 1 year ago

My compiled version of Paraview is a binary that supports it.

P.s. :stuck_out_tongue:

jorgensd commented 1 year ago

My compiled version of Paraview is a binary that supports it.

P.s. :stuck_out_tongue:

What version is that? I looked at the source code the other day, and it didn't seem the pr adding this support made it to the last release (5.11.1).

massimiliano-leoni commented 1 year ago

I compile master and in any case I will compile whatever it takes to get that feature :D