search

FEniCS / dolfinx

Next generation FEniCS problem solving environment
https://fenicsproject.org
GNU Lesser General Public License v3.0
794 stars 182 forks source link

Allow mixed element with single element #3520

Closed jorgensd closed 1 week ago

jorgensd commented 1 week ago

Resolve #3519

garth-wells commented 1 week ago

See https://github.com/FEniCS/basix/pull/882.

jorgensd commented 1 week ago

See FEniCS/basix#882.

This doesn’t resolve the issue, as you then forces the external library to handle two different cases: If they only have a single elements, go down one code path, if there are multiple, do something completely different.

this is because one relies on .sub(i) for interpolation, boundary condition etc. and a normal element without block size doesn’t have a sub(0).

RemDelaporteMathurin commented 1 week ago

Based on discussions https://github.com/FEniCS/dolfinx/issues/3519#issuecomment-2487700838 I think we now agree this is a valid fix for now until future changes in the element vs mixed element architecture