`CellType.name` is not portable between c++ wrapper implementations

FEniCS / ffcx

Next generation FEniCS Form Compiler for finite element forms

https://fenicsproject.org

Other

145 stars 38 forks source link

`CellType.name` is not portable between c++ wrapper implementations #573

Closed chrisrichardson closed 1 year ago

chrisrichardson commented 1 year ago

CellType is an enum and when we use CellType.name this is a specific extension used by pybind11. If we switch to nanobind, the same string is called CellType.__name__.

To be more portable, we should use a function to get the name of the CellType.

chrisrichardson commented 1 year ago

https://github.com/FEniCS/basix/actions/runs/5243920871