search

FEniCS / ffcx

Next generation FEniCS Form Compiler for finite element forms
https://fenicsproject.org
Other
145 stars 38 forks source link

Fix bug that led to Quadrature Elements not being blocked. #583

Closed jhale closed 1 year ago

jhale commented 1 year ago

The order of the logic in element_interface.py led to the built in FFCx type QuadratureElement always being handled prior to the call to Basix's block element. This PR changes this to handle elements in order of higher-order types, FFCx types, and then finally UFL types.

It's not clear to be what the modern 'basix' way to handle QuadratureElements might be (regarding the warning).

jhale commented 1 year ago

I've figured out how to construct the element with modern FFCx and Basix element constructors (rather than UFL) so I'll make that change first.