Should we add float32 dolfinx tests to CI?

FEniCS / ffcx

Next generation FEniCS Form Compiler for finite element forms

https://fenicsproject.org

Other

145 stars 38 forks source link

Should we add float32 dolfinx tests to CI? #607

Closed mscroggs closed 1 year ago

mscroggs commented 1 year ago

This might be useful to catch issues like https://github.com/FEniCS/dolfinx/issues/2762 while there's lots of changes happening in FFCx

garth-wells commented 1 year ago

We should parameterise more tests over the scalar type. Any test that depends on the scalar type and doesn't depend on PETSc can be parameterised over the type. This will take care of most issues.

garth-wells commented 1 year ago

Parameterised mored DOLFINx tests over scalar type in https://github.com/FEniCS/dolfinx/pull/2765.

Should keep parameterising more.