search

FEniCS / fiat

FIAT is now maintained at https://github.com/firedrakeproject/
https://fenicsproject.org/
GNU Lesser General Public License v3.0
33 stars 21 forks source link

Don't throw away supporting entities of dofs #19

Open chrisrichardson opened 8 years ago

chrisrichardson commented 8 years ago

Original report by Jan Blechta (Bitbucket: blechta, GitHub: blechta).

Information about supporting entities of dofs is thrown away in some subclasses of FiniteElement, e.g. DiscontinuousLagrange. The information is readily available - support entities of DiscontinuousLagrange are the same as Lagrange.entity_dofs() - but just thrown away.

The information is then needed to be recovered with hacks like FiniteElement.facet_support_dofs() and dolfin::DirichletBC::compute_bc_geometric.

Implement FiniteElement.support_entity_dofs().

chrisrichardson commented 8 years ago

Original comment by Lawrence Mitchell (Bitbucket: wence, GitHub: wence).

I note that the Strang-Fix scheme (the canonical one) is a symmetric quadrature rule, whereas the four-point collapsed quadrature is non-symmetric. This may or may not be an issue.