search

FEniCS / performance-test

Mini App for FEniCSx performance testing
MIT License
15 stars 6 forks source link

Fix num_entities by using explicit math formula for counting #155

Open createyourpersonalaccount opened 2 months ago

createyourpersonalaccount commented 2 months ago

While reading the source code searching for issues with some crashes I have with this software (I still haven't figured out why there's crashes but I've noticed that under gdb I can no longer obtain them, which means they're sensitive to timing, I think) I noticed this cell-counting function was doing some unnecessary work; I simplified it with the right formula.

francesco-ballarin commented 1 month ago

cc @chrisrichardson. FYI, @createyourpersonalaccount is doing a GSOC project with Debian.

@createyourpersonalaccount , it would be good if you could modify the message in the first post adding a couple of sentences on what motivated you to propose this PR, so that anyone who will find this PR in future will be able to remember what the rationale was.

createyourpersonalaccount commented 1 month ago

@francesco-ballarin I edited the original PR message to include some information.