FEniCS / ufl

UFL - Unified Form Language
https://fenicsproject.org
GNU Lesser General Public License v3.0
104 stars 64 forks source link

`typing_extensions` breaks Spack build #174

Closed garth-wells closed 1 year ago

garth-wells commented 1 year ago

See https://github.com/FEniCS/dolfinx/actions/runs/5407842569/jobs/9826291336.

Is it essential?

wence- commented 1 year ago

I suppose not, it's a backport package for new type annotation features to older python versions. Is this happening because the spack build doesn't install dependencies in the same way? Or because we forgot to add it as a dependency in pyproject?

garth-wells commented 1 year ago

Dependencies need to be listed explicitly with Spack, see https://spack.readthedocs.io/en/2021.08.19/build_systems/pythonpackage.html#python-dependencies for the reasons.

garth-wells commented 1 year ago

typing_extensions is used to type hint very few 'private' methods, probably not justifying the introduction of a dependency. Easiest would be to remove. Docs can explain the type.