search

FEniCS / ufl

UFL - Unified Form Language
https://fenicsproject.org
GNU Lesser General Public License v3.0
97 stars 64 forks source link

Remove IrreducibleInt #213

Closed mscroggs closed 12 months ago

mscroggs commented 12 months ago

Remove the IrreducibleInt hack.

It seems locally that all the tests pass without it...

This is coupled with https://github.com/FEniCS/basix/pull/702

wence- commented 12 months ago

It's a long time, but I think this hack was put in because the simplex-based degree estimation code under-estimates the degrees of integrals on hypercubes (for reasons that I do not recall 😞 )

mscroggs commented 12 months ago

It's a long time, but I think this hack was put in because the simplex-based degree estimation code under-estimates the degrees of integrals on hypercubes (for reasons that I do not recall 😞 )

Yes, the docstring of _reduce_degree says that's done but also not why. I think I've achieved the same result by checking the cell type inside _reduce_degree:

https://github.com/FEniCS/ufl/blob/9e5884c2b767cf7d6325120d9843f5df76e2ac7f/ufl/algorithms/estimate_degrees.py#L99