Remove geometric dimension from cell, move value_shape to FunctionSpace

mscroggs commented 8 months ago

The element needed to know the geometric domain to know the physical value size. With the value size functions moved to FunctioSpace, the geometric domain can instead be obtained from the mesh/domain and the cell no longer needs a gdim.

This PR moves toward these aims that I propose that we follow:

Cell and FiniteElement can always be thought of as the reference cell and element defined on the reference cell
All information about geometric space belongs to the domain (the Mesh object)

Coupled with FEniCS/basix#772, FEniCS/ffcx#653, FEniCS/dolfinx#2996.

The draft changes in https://github.com/FInAT/FInAT/pull/118 and https://github.com/firedrakeproject/tsfc/pull/307 will be needed once this is merged into Firedrake's fork of UFL.

garth-wells commented 7 months ago

@mscroggs is this ready to merge? I don't want to try ruff/black formatting before this PR is wrapped up.

mscroggs commented 7 months ago

@mscroggs is this ready to merge? I don't want to try ruff/black formatting before this PR is wrapped up.

Ran out of time to sort this today. I'll update the coupled PRs and get this merged over the weekend.

FEniCS / ufl

Remove geometric dimension from cell, move value_shape to FunctionSpace #249