FFDA / SourCherry

Android app to open CherryTree databases
GNU General Public License v3.0
68 stars 3 forks source link

Omit marked to exclude checkbox default #15

Closed metal450 closed 1 year ago

metal450 commented 1 year ago

A couple suggestions:

The issue: I keep finding myself doing a search, realizing that it's including all of my "trash" nodes again, re-checking the checkbox, then it erases what I've typed so I have to retype it again.

Thanks!

FFDA commented 1 year ago

I actually planed to release 1.3.0-beta as a normal version tomorrow. So I will delay it a bit and add these requested features to that release.

Also, checking/unchecking this checkbox clears any typed text.

Just fixed this. I actually did it on purpose, because previously after checking that checkbox user would have had to type (or delete) a symbol for it to have any effect.

app is launched, it forgets the previous setting for "Omit marked to exclude."

I'll make it to remember the choice. At least in my twisted mind it should be off by default.

metal450 commented 1 year ago

Great, thanks!

I actually did it on purpose, because previously after checking that checkbox user would have had to type (or delete) a symbol for it to have any effect.

Or could just make the check/uncheck action raise an event to trigger a new search?

FFDA commented 1 year ago

Or could just make the check/uncheck action raise an event to trigger a new search? That's what I did.

I just released new version on Play Store and on GitHub. It includes both changes to FilterNodes function.

metal450 commented 1 year ago

Great, it works - thanks!!