FFFFFFFXXXXXXX / league_record

Record League of Legends games
Other
34 stars 2 forks source link

videos don't show any info #12

Closed danollo closed 8 months ago

danollo commented 8 months ago

image

all videos look like this, 0/0 statline with no champ identifier (idk if the champ part was ever a thing)

FFFFFFFXXXXXXX commented 8 months ago

Thanks for the issue, could you set "debugLog":true in the settings and post the logs from the %APPDATA%/fx.LeagueRecord/logs/.

danollo commented 8 months ago

2024-01-17_16-54.log

FFFFFFFXXXXXXX commented 8 months ago

I assume you have the close client during game setting in the LeagueClient set to always? Currently the app tries to connect to the API of the LeagueClient for information about the player and about the players stats. Which is not possible if the client stops running during the game.

I'll have to take this into consideration in the future.

For now setting close client during game to never should fix the problem.

FFFFFFFXXXXXXX commented 8 months ago

Actually I released a quick fix: https://github.com/FFFFFFFXXXXXXX/league_record/releases/tag/v1.15.5 Does that fix the issue?

danollo commented 8 months ago

v1.15.5 fixed the issue - thanks!