search

FFFFFFFXXXXXXX / league_record

Record League of Legends games
Other
34 stars 2 forks source link

[FEATURE REQUEST] Store whether "Classic" game is soloduo/flex/draft/quickplay #17

Closed ceselder closed 7 months ago

ceselder commented 7 months ago

Right now, these are all marked as "Game mode: Classic". I can't imagine the LCU doesn't provide a way to differentiate between them, since the post screen lobby does show stuff like lp gains and it must be getting them from the /lol-end-of-game/ endpoint that you use, right?

LCU is documentation hell, so I'm not sure whether this is 100% the case though.

I'd try to implement it myself but sadly I've never written rust before

FFFFFFFXXXXXXX commented 7 months ago

Yeah, the "gameMode" in the metadata is a bit of a misnomer. It actually is just the type of map that's being played. So ARAM, Summoners Rift or Twisted Treeline (doesn't exist anymore). And for some reason Practicetool is it's own type of "Map" because of riots spaghetti code.

I'll have to look a little more into how to best get this information because (like everything else LoL API related) it's a big mess. I am pretty sure it's possible tho.

FFFFFFFXXXXXXX commented 7 months ago

duplicate of #18