search

FFFFFFFXXXXXXX / league_record

Record League of Legends games
Other
34 stars 2 forks source link

[bug] "no data" when finishing game with the webview open #22

Closed ceselder closed 6 months ago

ceselder commented 6 months ago

Will reliably show "no data" when finishing ranked games if leaguerecord was open but not in tray. IF it is in tray it behaves as expected.

I know you've been tracking down this bug for a while (I think)? So I hope this helps.

FFFFFFFXXXXXXX commented 6 months ago

EDIT: nvm, you are saying no data gets saved if the app is open when the game is finished and #23 is about the data showing up late. Is this specific to ranked games? Because I can't replicate this in a custom game or practicetool game.

~I am a little confused what the difference between this and #23 is.~ ~Could you describe the problem a little more?~

Currently the recording shows up in the UI as soon as the game ends. The metadata about the game only gets collected as soon as the data is available - which is the same time the post game lobby is ready.

So the intended behaviour looks something like this. Game starts / no recording in UI -> game ends / recording in UI but no data -> post game lobby is ready / metadata shows up automatically in UI.

Which means if you wait a little the metadata should show up by itself. Is this not the case?

ceselder commented 6 months ago

I think it might be specific to ranked games yes. The metadata never shows up however.

FFFFFFFXXXXXXX commented 6 months ago

Please enable logs in the settings and post them if it happens again.

I haven't found away to replicate the bug yet.

FFFFFFFXXXXXXX commented 6 months ago

fixed in v1.19.2

ceselder commented 6 months ago

Thank you so much! What did the bug end up being? (dw if its too logn to explain or you cba)

FFFFFFFXXXXXXX commented 6 months ago

It was something stupid. I was parsing/deserializing the current_gold of the players in the timeline-data to a u64, but it can be negative when a player uses the futures market rune.

I'm think players are way more likely to use futues market in ranked and this was the problem, not the ranked gamemode. And the window open/closed was just coincidental. But feel free to re-open the issue if I'm wrong and the issue still persists.

ceselder commented 6 months ago

incredible, thats really funny. Thanks for fixing it