search

FFFFFFFXXXXXXX / league_record

Record League of Legends games
Other
36 stars 2 forks source link

Add YouTube upload support #27

Open nymann opened 5 months ago

nymann commented 5 months ago

First of all, thank you for a great piece of software.

I was wondering if it would make sense to add a YouTube upload feature that adds the markers (JSON metadata) as chapters.

FFFFFFFXXXXXXX commented 5 months ago

Hey, how would you imagine this feature to look like? An 'upload' button next to rename, delete, ... that uploads the video to youtube?

I assume the general goal is to upload the recording somewhere in order to make it shareble?

nymann commented 5 months ago

Maybe it's better to just have a separate program for it honestly. I'll cook something up, when I get the will power 😅

I was thinking something that just automatically uploads your video to YouTube as unlisted (for long term storage and sharing).

FFFFFFFXXXXXXX commented 5 months ago

I'm not against that feature here are my rough thoughts on what I need to consider:

  1. how to integrate the feature into the UI
  2. should the user need to click a button to manually upload a video or should all videos be auto-uploaded
  3. should uploads be paused during a game because some peoples internet connection isn't good enough / does the youtube api support pausing uploads?

In case you use JS/TS for your own solution, there are .d.ts definitions of the metadata file format here.

nymann commented 5 months ago

I'm not against that feature here are my rough thoughts on what I need to consider:

1. how to integrate the feature into the UI

2. should the user need to click a button to manually upload a video or should all videos be auto-uploaded

3. should uploads be paused during a game because some peoples internet connection isn't good enough / does the youtube api support pausing uploads?

In case you use JS/TS for your own solution, there are .d.ts definitions of the metadata file format here.

If it was to be integrated, I would just start with having it as a setting in the JSON file, and then auto upload it. Then you could always extend that to support manual uploads via the UI in the future as well.

btvoidx commented 3 months ago

Hi! I would like to hijack this discussion in favor of a general built-in clip-maker. As in, select starting position and an ending position, click "save" button to bring up system file save dialog and that's it.

Then said clip could just be drag-and-dropped into youtube upload menu; I see no point in making a separate button for YouTube. After all, you can share videos on many websites.

FFFFFFFXXXXXXX commented 3 months ago

I guess I'll use this opportunity for a quick update.

There are 2 things going on:

  1. I currently don't have much time for adding extra features so if I find time I was thinking about adding a feature that just exports the timestamps as youtube timestamps. You would need to upload the video yourself, but you could paste the timestamps in the description of the video.
  2. Doing 1. is blocked on finishing v2 of the app (see v2 branch). The code wasn't really well structured for adding additional features so I wanted to restructure some things, change the installer used, add an auto-updater and update the GUI framework major version. All of that is like 2/3 done but I never quite got around to finishing it.

As soon as Riot breaks some things again I'll probably find the motivation/time to finish v2 and after that some version of this feature.

In regards to @btvoidx I think adding a full-on clipmaker is outside the scope of the project.

FFFFFFFXXXXXXX commented 1 month ago

v2.0.0 is out now with a button to copy the timeline events to the clipboard formatted as youtube timestamps. would be interesting to hear if it works as intended or if I can improve the user experience in any way