search

FFIG / ffig

Generate code to call C++ libraries from other languages
MIT License
29 stars 9 forks source link

Simplify Java targets with CMake 3.12 list(join ...) #466

Closed jbcoe closed 5 years ago

jbcoe commented 5 years ago

What does this PR do?

Simplifies Java CMake targets using list(join ...) from CMake 3.12

philipcraig commented 5 years ago

Does this also increase Cmake version requirements on ffig users, or just on the ffig developers?

jbcoe commented 5 years ago

This increases the minimum CMake version for anyone who wants to use FFIGs CMake rules.

It's not clear that requiring CMake 3.12 is a direction we want to take.

Happy to stall this PR until Ubuntu LTS supports CMake 3.12.

philipcraig commented 5 years ago

In that case I agree on parking it as it may hinder adoption without much user benefit