search

FFMS / ffms2

An FFmpeg based source library and Avisynth/VapourSynth plugin for easy frame accurate access
Other
588 stars 104 forks source link

Audio dumping silently does nothing #153

Closed nixxquality closed 10 years ago

nixxquality commented 10 years ago

Turns out, the last time this worked properly was in 2.17.

I tried running both ffmsindex.exe from the releases page of version 2.17 and 2.19 and, using the same arguments, only the 2.17 exe dumped the audio file.

>ffmsindex.exe -d -1 test.mkv
Indexing, please wait... 100%
Writing index... done.

Note that no error message is printed nor is any kind of exception thrown. It just doesn't do anything.

I'm not sure exactly what caused this regression, or if it's still happening in master, but it might be worth looking into.

I would check it out myself, but I can't compile ffms2 on my PC -- MinGW is being rude.

tgoyne commented 10 years ago

I'm not sure if the audio dumping even makes much sense anymore. The original idea was that we had to fully decode the audio to be able to index it, so it was wasteful to just discard the decoded result, but that hasn't been totally true ever since lavc switched to outputting planar audio.

qyot27 commented 10 years ago

I would check it out myself, but I can't compile ffms2 on my PC -- MinGW is being rude.

It still happens in master...or reasonably close, as I doubt the last four commits or so would have changed this at all. r887+41 doesn't dump audio with -d -1.