SWResample Support / Visual Studio compiled libraries

[slajar]

• actual supporting swresample instead of avresample (was already configurable with WITH_SWRESAMPLE)
• supporting VS compiled FFMPEG/AV libs

[tgoyne]

The last few releases have been built with msvc-compiled FFmpeg without any sort of renaming of the FFmpeg-built files, so any claims that that doesn't work are automatically rather dubious.

[slajar]

I see, I will try to find a macro'ish way to get rid of the duplicate code :)

[slajar]

Does anyone have an idea what is wrong? It seems that travis builds correctly for ffmpeg but not for libav. ASAIK, I haven't changed anything there.

[dwbuiten]

src/core/audiosource.cpp: In member function ‘void FFMS_AudioSource::SetOutputFormat(const FFMS_ResampleOptions&)’:

src/core/audiosource.cpp:213:82: error: ‘av_opt_set_channel_layout’ was not declared in this scope

  av_opt_set_channel_layout(newContext, "out_channel_layout", opt.ChannelLayout, 0);

                                                                                  ^

src/core/audiosource.cpp:215:89: error: ‘av_opt_set_sample_fmt’ was not declared in this scope

  av_opt_set_sample_fmt(newContext, "out_sample_fmt", (AVSampleFormat)opt.SampleFormat, 0);

[slajar]

Can I do something to get this pull request accepted?

[qyot27]

Can I do something to get this pull request accepted?

You could pay attention to the git log, because the support for swresample was already committed four days ago.

This pull request is dirtied up by those revert commits that revert commits that only ever existed in this pull request, there's no way they'd merge them when those commits should be squashed (and as I said, swresample got added already).