Crash in FFMS_SetOutputFormatV2 with mp4 file

[myier]

Hello, I am developing the capability to export frames as an mp4 film in siril, the astronomy image processor. We've been using ffms2 for some time without problem now, but when I try to open any of the newly created mp4, it crashes when calling FFMS_SetOutputFormatV2.

It is probable that the created mp4 file has some kind of issue, though it plays back just fine in mpv and mplayer. mplayer gives this warning that might help: "Movie-Aspect is undefined - no prescaling applied.".

If I can make a movie faulty enough to have ffms2 crash, I guess it's worth fixing, and probably while fixing it you will also tell me what is wrong with the created film so that I can fix it as well.

Here are some useful resources:

• an example mp4 that makes it crash: https://free-astro.org/videos/ffms_bug.mp4 (that's Mars in case you're wondering)
• the source code of our ffms2 integration: https://free-astro.org/svn/siril/trunk/src/io/films.c
• the source code of our ffmpeg mp4 and webm output integration, based on the muxing.c example but updated to the new ffmpeg API: https://free-astro.org/svn/siril/trunk/src/io/mp4_output.c

Any help would be appreciated. Thank you very much again for developing FFMS2!

[myier]

Ok, apparently you already fixed it because I can't reproduce any error with the git version instead of version 2.22.