search

FFTW / fftw3

DO NOT CHECK OUT THESE FILES FROM GITHUB UNLESS YOU KNOW WHAT YOU ARE DOING. (See below.)
GNU General Public License v2.0
2.67k stars 652 forks source link

CMake: Adding support for building multiple precisions at once #276

Open emmenlau opened 2 years ago

emmenlau commented 2 years ago

This PR allows to build multiple (or all) precisions in a single go in cmake. Please let me know what you think?

emmenlau commented 2 years ago

The PR does not fully work out of the box, because it will not select the sources dynamically for the precision. I can provide an improved version if this is relevant at all?

emmenlau commented 1 year ago

Hi @LecrisUT , thanks for your interest to push the cmake support forward, it's appreciated. However I should note that currently the commit CMakeLists.txt: Support multi-precision builds is broken because it makes some wrong assumption about which code needs to be built. I don't even recall the details but there was a flaw that requires slightly larger re-design of the change.

LecrisUT commented 1 year ago

The only part that I can see is the lack of target_compile_definitions for FFTW_SINGLE etc. Check these lines: https://github.com/FFTW/fftw3/blob/9426cd59106ffddde1f55131c07fa9c562fa2f8e/kernel/ifftw.h#L63-L78

emmenlau commented 1 year ago

Hi @LecrisUT , thanks for your interest to push the cmake support forward, it's appreciated. However I should note that currently the commit CMakeLists.txt: Support multi-precision builds is broken because it makes some wrong assumption about which code needs to be built. I don't even recall the details but there was a flaw that requires slightly larger re-design of the change.

Hey @LecrisUT , I've re-considered this PR and I'm not sure whether there is a problem with my changes or not. It may help if you could try the fftw built with these instructions here and see if it is any faster or slower than the "common" fftw. Is that something you can test?

LecrisUT commented 1 year ago

Honestly I have completely lost interest in contributing to modernizing this project after the comments in #307. I have no hope that any improvements we make will be considered. Cmake fully supports OCaml and the project can be made to be fully compiled with cmake, but until that is being considered I don't think I'll participate.

JiahanBro commented 1 year ago

Von: Cristian Le @.> Gesendet: Sonntag, 25. Juni 2023 23:03 An: FFTW/fftw3 @.> Cc: Subscribed @.***> Betreff: Re: [FFTW/fftw3] CMake: Adding support for building multiple precisions at once (PR #276)

Honestly I have completely lost interest in contributing to modernizing this project after the comments in #307https://github.com/FFTW/fftw3/issues/307. I have no hope that any improvements we make will be considered. Cmake fully supports OCaml and the project can be made to be fully compiled with cmake, but until that is being considered I don't think I'll participate.

— Reply to this email directly, view it on GitHubhttps://github.com/FFTW/fftw3/pull/276#issuecomment-1606260689, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGRKXG5PKUEJZGATTK3P2WTXNCRRZANCNFSM5QKYXOPA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

LecrisUT commented 1 year ago

@JiahanBro, did you meant to forward that message internally or make a comment?