FFXIV-CombatReborn / RotationSolverReborn

Analyses combat information every frame and finds the best action.
https://github.com/FFXIV-CombatReborn/RotationSolverReborn
GNU Lesser General Public License v3.0
47 stars 41 forks source link

[Bug] RSR making several thousands of the data cache tag "Avarice.ActionOverride" #169

Closed BrakusTapus closed 4 months ago

BrakusTapus commented 4 months ago

RSR version: v4.1.1.9

As soon as RSR is on thousands of these will be made until user either turns RSR off completely or closes the game. Occurs when Avarice is not installed or is installed. Is this intentional?

image ffxiv_dx11_Ij0U5wZP7h

spaceelysian commented 4 months ago

private static void SetAction(uint id) => Svc.PluginInterface.GetOrCreateData( "Avarice.ActionOverride", ( ) => new List<uint>( ) {id} ) [0] = id;

I think it has something to do with this bit of code. Is it because a new list is created every time?

BrakusTapus commented 4 months ago

private static void SetAction(uint id) => Svc.PluginInterface.GetOrCreateData( "Avarice.ActionOverride", ( ) => new List<uint>( ) {id} ) [0] = id;

I think it has something to do with this bit of code. Is it because a new list is created every time?

Yeah it's creating a new list because of that line of code, the same bug was present in the orginal RS but has been fixed

https://github.com/ArchiDog1998/RotationSolver/pull/623

NostraThomas99 commented 4 months ago

Fixed in #172