search

FFXIVAPP / ffxivapp

Visit us on Discord! https://discord.gg/aCzSANp
https://xivapp.com
MIT License
89 stars 45 forks source link

handle more inventory container in InventoryWorker #44

Closed violet2016 closed 9 years ago

violet2016 commented 9 years ago

Please notice it need the merge request of ffxivapp-common. Also, the SetCharacterName function is needed for character's item catalog storage. Not sure if it will affect the Constants event. Please review it:)

Icehunter commented 9 years ago

I'm merging this in today but I will be moving the SetCharacterName. Whenever you set a constant variable it will actually call update constants on the interface for plugins automatically.

You can see this here:

https://github.com/Icehunter/ffxivapp/blob/master/FFXIVAPP.Client/Constants.cs#L126

So I will be setting the character name here instead:

https://github.com/Icehunter/ffxivapp/blob/master/FFXIVAPP.Client/Memory/MonsterWorker.cs#L177

That is always "you".

I'll also be updating the naming system so it's not first/last anymore and instead is just "Name"