search

FFmpeg / FFV1

The FFV1 lossless video codec specification.
Other
155 stars 35 forks source link

Golomb Rice description fixes #207

Closed JeromeMartinez closed 4 years ago

JeromeMartinez commented 4 years ago

More AD review updates, these ones are focused on Golomb Rice description (1 section inversion & 1 function definition).

Fix https://github.com/FFmpeg/FFV1/issues/174.

michaelni commented 4 years ago

About sign_extend, this maybe should mention twos complement somewhere

michaelni commented 4 years ago

applied the first patch of the 2

JeromeMartinez commented 4 years ago

About sign_extend, this maybe should mention twos complement somewhere

I added this wording in the section introduction, please review again. (argh, too late for the -14 release :-p)

JeromeMartinez commented 4 years ago

@dericed please review again.

michaelni commented 4 years ago

The first hunk seems unrelated

JeromeMartinez commented 4 years ago

The first hunk seems unrelated

I have split the commit in 2.