Closed michaelni closed 3 years ago
hmmm for me
% make clean
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
rm -f ffv1.pdf ffv1-v4.pdf ffv1.html ffv1-v4.html draft-ietf-cellar-ffv1-* merged_*
% make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V4}" | sed "s|^AART:||g;s|{V3}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-17.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Created file draft-ietf-cellar-ffv1-17.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.txt"
Created file draft-ietf-cellar-ffv1-17.txt
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V3}" | sed "s|^AART:||g;s|{V4}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-v4-14.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-v4-14.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-v4-14.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-v4-14.xml"
bash svg2src "draft-ietf-cellar-ffv1-v4-14.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.html"
Created file draft-ietf-cellar-ffv1-v4-14.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.txt"
Created file draft-ietf-cellar-ffv1-v4-14.txt
% mmark --version
2.2.9
% xml2rfc --version
xml2rfc 2.47.0
% xmlstarlet --version
1.6.1
compiled against libxml2 2.9.4, linked with 20904
compiled against libxslt 1.1.29, linked with 10129
% pdfcrop --version
pdfcrop 2012/11/02 v1.38
OK my mmark is ahead of yours (2.2.8 -> 2.2.9) and xml2rfc is ahead (2.47.0 -> 2.41.0).
I see that your svg includes a g/@style
attribute and the symbol
element that causes most of the errors, but those are addressed in https://github.com/FFmpeg/FFV1/blob/d188994cb84900cdd0c83c06f75656753217a911/makesvg#L13-L15. Do you mind deleting the svg files and rerunning the make process.
Do you mind deleting the svg files and rerunning the make process.
are you asking me or "make clean" ? "make clean" says its creators forgot and its really sad it cannot.
I was asking you. If helpful, we could add the svg files to make clean.
ok, fails worse :) ill show the relevant one: makesvg: line 9: pandoc: command not found and before you say install pandoc, yes of course but that requirement is not documented it should be documented and ideally tested for
and after installing pandoc it fails even more
make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
bash makesvg
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Traceback (most recent call last):
File "/home/michael/.local/bin/xml2rfc", line 11, in <module>
sys.exit(main())
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/run.py", line 649, in main
xmlrfc.tree = prep.prep()
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/writers/preptool.py", line 355, in prep
func(e, e.getparent())
File "/home/michael/.local/lib/python2.7/site-packages/xml2rfc/writers/preptool.py", line 1826, in element_artwork
svg = etree.fromstring(data)
File "src/lxml/etree.pyx", line 3235, in lxml.etree.fromstring
File "src/lxml/parser.pxi", line 1876, in lxml.etree._parseMemoryDocument
File "src/lxml/parser.pxi", line 1764, in lxml.etree._parseDoc
File "src/lxml/parser.pxi", line 1127, in lxml.etree._BaseParser._parseDoc
File "src/lxml/parser.pxi", line 601, in lxml.etree._ParserContext._handleParseResultDoc
File "src/lxml/parser.pxi", line 711, in lxml.etree._handleParseResult
File "src/lxml/parser.pxi", line 640, in lxml.etree._raiseParseError
File "<string>", line 1
lxml.etree.XMLSyntaxError: Document is empty, line 1, column 1
Makefile:26: recipe for target 'draft-ietf-cellar-ffv1-17.html' failed
make: *** [draft-ietf-cellar-ffv1-17.html] Error 1
also if i manually delete *.svg again and run make clean and then make it seems working but i shouldnt have to do this
make clean
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
rm -f ffv1.pdf ffv1-v4.pdf ffv1.html ffv1-v4.html draft-ietf-cellar-ffv1-* merged_*
rm *.svg
make
RFC rendering has been tested with mmark version 2.2.8, xml2rfc 2.32.0, xmlstarlet 1.6.1, pdfcrop v1.38, and pdf2svg 0.2.3, please ensure these are installed and recent enough.
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V4}" | sed "s|^AART:||g;s|{V3}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-17.md
bash makesvg
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `quantizationtablesets.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `context.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rgb1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rgb2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `samplediff.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues3.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues4.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues5.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues6.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `rangebinaryvalues7.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `statetransitiontable1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `statetransitiontable2.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `initialstatedelta1.svg_cropped.pdf'.
PDFCROP 1.38, 2012/11/02 - Copyright (c) 2002-2012 by Heiko Oberdiek.
==> 1 page written on `initialstatedelta2.svg_cropped.pdf'.
mmark "draft-ietf-cellar-ffv1-17.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-17.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-17.xml"
bash svg2src "draft-ietf-cellar-ffv1-17.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.html"
Created file draft-ietf-cellar-ffv1-17.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-17.xml" -o "draft-ietf-cellar-ffv1-17.txt"
Created file draft-ietf-cellar-ffv1-17.txt
cat rfc_frontmatter.md "ffv1.md" rfc_backmatter.md | grep -v "^AART:" | grep -v "^SVGC" | grep -v "{V3}" | sed "s|^AART:||g;s|{V4}||g;s|SVGI:||g;s|@BUILD_DATE@|2020-09-30|" > draft-ietf-cellar-ffv1-v4-14.md
bash makesvg
mmark "draft-ietf-cellar-ffv1-v4-14.md" | sed 's|<date year="undated"></date>|<date>undated</date>|g' > "draft-ietf-cellar-ffv1-v4-14.xml"
xmlstarlet edit --inplace --insert "/rfc" --type attr -name sortRefs -v "true" "draft-ietf-cellar-ffv1-v4-14.xml"
bash svg2src "draft-ietf-cellar-ffv1-v4-14.xml"
xml2rfc --html --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.html"
Created file draft-ietf-cellar-ffv1-v4-14.html
xml2rfc --v3 "draft-ietf-cellar-ffv1-v4-14.xml" -o "draft-ietf-cellar-ffv1-v4-14.txt"
Created file draft-ietf-cellar-ffv1-v4-14.txt
Hi @michaelni, I certainly don't disagree and had attempted to address this in the buildcheck
script, adapted from @robUx's work at https://github.com/FFmpeg/FFV1/pull/222. I'm not blocking the idea from happening, but I don't know how to do it at the moment.
@dericed, ok, i understand. so i tried adding a version check and ended up with https://github.com/FFmpeg/FFV1/pull/236
closing in favor of https://github.com/FFmpeg/FFV1/issues/240 which is about the remaining issue
This makes it hard to identify newly added bugs in patches In fact i cannot show the whole list of errors as github refuses to accept the full list "There was an error creating your Issue: body is too long (maximum is 65536 characters)." so this is shortened