search

FFmpeg / FFV1

The FFV1 lossless video codec specification.
Other
154 stars 35 forks source link

Ballot Barry part 2 #241

Closed JeromeMartinez closed 3 years ago

JeromeMartinez commented 3 years ago

A couple of patches partially fixing Barry Leiba's Discuss.

dwbuiten commented 3 years ago

Is it useful to mention % means C-style modulo, and no "math-style" modulo?

JeromeMartinez commented 3 years ago

Is it useful to mention % means C-style modulo, and no "math-style" modulo?

Checking if we use % on negative numbers, I see that it is actually not used (or did I miss something?), so a way to avoid to have to be more precise is to just remove it from the Order of Operation Precedence :). PR updated with removal of % in Order of Operation Precedence.

JeromeMartinez commented 3 years ago

The only missing part is the get_rac stuff.

dericed commented 3 years ago

@JeromeMartinez I'll move the get_rac discussion to that issue as I think this PR is ready for merge. hoping @michaelni agrees :)