search

FFmpeg / FFV1

The FFV1 lossless video codec specification.
Other
154 stars 35 forks source link

Typos and clarity #259

Closed dericed closed 3 years ago

dericed commented 3 years ago

Hi @michaelni, please review carefully and critically. Many of these commits are trivial but some rely on the current state of my understanding for how range coding works within FFV1 encodings. I'd like to do a little more work on this after this PR, but want to submit it at this point to ensure that my understanding of your work is correct and/or well-expressed.

This PR builds upon the discussions within https://github.com/FFmpeg/FFV1/issues/258 and https://github.com/FFmpeg/FFV1/issues/231.

Note that the PR changes many of the LaTeX formula, while https://github.com/FFmpeg/FFV1/issues/240 is still open, so please run rm -v *.svg before make.

michaelni commented 3 years ago

"The value of j_n which tracks the length of the bytestream is initialized to 2" j_i tracks the length as i changes from 0 over several steps to n the first which is j_0 is initialized to 2, j_n is the last

dericed commented 3 years ago

Hi @michaelni, I updated the description of j_(i) in https://github.com/FFmpeg/FFV1/pull/259/commits/f05b69119050fa0122cbf05d3c715aa1e8f724a5.

dericed commented 3 years ago

updated and ready for re-review

dericed commented 3 years ago

friendly nudge :) as I'd like to continue on this work