search

FG-Unofficial-Developers-Guild / FG-Aura-Effect

This extension accommodates auras and AoE buffs/debuffs by adding/removing effects to other characters based on proximity.
https://www.fantasygrounds.com/forums/showthread.php?57417-5E-Aura-Effects
Other
13 stars 2 forks source link

Empty Effect Lines Left Over #9

Closed jputman closed 3 years ago

jputman commented 3 years ago

As tokens move in and out of the Aura range it sometimes is leaving behind an empty effect line that has to be manually removed. See image for example.

2021-05-19 21_06_16-Fantasy Grounds

jputman commented 3 years ago

I am not sure the exact root cause of this, as I can not actually easily replicate it, but I have seen it a few times. It only shows up if you expand a sheet in the CT as they are blank so if it is collapsed nothing appears to be out of the ordinary.

bmos commented 3 years ago

oh, interesting! thanks for the report.

SoxMax commented 3 years ago

I saw this in my game last night too. I think its related to unlocked token movement, I'll see if I can pin it down tonight.

jputman commented 3 years ago

Awesome. Thanks for the hard work. It has been working great other than that. glad that it wasn't just me. :) Makes me feel less crazy.

SoxMax commented 3 years ago

Update on this. I've had difficulty reproducing. I think it only pops up with more network latency than I can generate locally. I have a game coming up this week though that should have that and I'll see if bmos latest changes will have inadvertently fixed it. Otherwise I'll see if I can get a few of them to stick around for testing.

jputman commented 3 years ago

I have a game tomorrow as well, and will keep an eye on it.

bmos commented 3 years ago

I could also connect to your host SoxMax if you aren't able to do testing.

bmos commented 3 years ago

@jputman are you still seeing this issue as of v1.2?

SoxMax commented 3 years ago

Argh I saw this show up in my game again. Back to trying to reproduce reliably.

bmos commented 3 years ago

Argh I saw this show up in my game again. Back to trying to reproduce reliably.

Are you using the silent effect option?

SoxMax commented 3 years ago

Ohh, that's really interesting with the DB listeners triggering off our own deletes. And yea I almost always use silent effects, else the chat window ends up overfilled. I actually think we could probably remove option and just make all AURA effects silent.

bmos commented 3 years ago

While I haven't had a game in FG for months so I can't say from personal experience, my preference is to leave the option as I would like those notices personally.

The remove handler, delete, re-add handler commit is to avoid potential errors which I sometimes see in the console upon closing the program. The error is something like "Object (DATABASENODE) deleted without cleaning up attached Lua object."

bmos commented 3 years ago

I believe this has been resolved