FGMEMBERS / 777

FG Aircraft | BASE | 777 by the Seattle group [https://gitlab.com/fg777_seattle/fg777_seattle.git]
https://gitlab.com/fg777_seattle/fg777_seattle
6 stars 15 forks source link

Fixed speedbrake not completly disabled with { key #7

Closed accek closed 7 years ago

accek commented 7 years ago

When disabling the speedbrakes using the keyboard, the lever is correctly moved to the ARMED position, but /controls/flight/speedbrake remains at 0.01, prompting SPEEDBRAKE EXTENDED warning at approach.

hyde-tech commented 7 years ago

Hello Szaymon,

I received this and checked today. Sorry for the late response. I notice that SPEEDBRAKE EXTENDED message is not displayed. I think that should be fixed before this. Why do you get that message? Any additional fix?

Regards, Hyde

On 2017年01月08日 08:42, Szymon Acedański wrote:

When disabling the speedbrakes using the keyboard, the lever is correctly moved to the ARMED position, but /controls/flight/speedbrake remains at 0.01, prompting SPEEDBRAKE EXTENDED warning at approach.


    You can view, comment on, or merge this pull request online at:

https://github.com/FGMEMBERS/777/pull/7

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FGMEMBERS/777/pull/7, or mute the thread https://github.com/notifications/unsubscribe-auth/ALSdOB3DXAIxU9R_vXB2oNeW0AaSW54eks5rQOfagaJpZM4LdsUe.

accek commented 7 years ago

I get the message in the following scenario:

  1. I use speedbrake in flight, to slow down the aircraft for approach.
  2. Then I want to move the lever to the ARM position using the keyboard: key {
  3. According to code in https://github.com/FGMEMBERS/777/blob/9f015837144d1d316326756526fa6d69629bef25/777-set-common.xml#L885, property controls/flight/speedbrake-lever will change to 1.0 (<min>1</min>).
  4. Before my fix (https://github.com/FGMEMBERS/777/pull/7/commits/ce7bfe89f78560a5db57a4413600469555eba7b1) the code there would not set the value of controls/flight/speedbrake to 0, because of the wrong comparison in the conditional statement. Therefore the speedbrake actuator was left at position 0.01. This does not significantly influence the aerodynamics as the speedbrake is almost stowed, but at low altitude this generates the SPEEDBRAKE EXTENDED EICAS message (https://github.com/FGMEMBERS/777/blob/c381b57a668b685bb2705601dc591b50e4307151/Nasal/warnsystem.nas#L244).
hyde-tech commented 7 years ago

Thank you,

I've taken this change.

Hyde