What do you think about changing english languages names on ISO 639‑1 or ISO 639‑3 language codes.

FGRibreau / node-language-detect

🇫🇷 NodeJS language detection library using n-gram

http://blog.fgribreau.com/2011/07/week-end-project-nodejs-language.html

MIT License

399 stars 45 forks source link

What do you think about changing english languages names on ISO 639‑1 or ISO 639‑3 language codes. #18

Closed SergeyKashulin closed 10 years ago

RuslanZavacky commented 11 years ago

Where will be the benefit? This standards are more popular? You can code additional implementation for this codes so they can work side by side with current implementation and create Pull Request.

SergeyKashulin commented 11 years ago

So you ok with adding methods detect6931(string) AND detect6393(string) ?

RuslanZavacky commented 11 years ago

I suggest writing PR request, I will review it, and then I will comment. Now its hard to understand what you really want to do. But you have to add tests & check performance as well. If everything will be ok, we will merge.