search

FGRibreau / node-unidecode

:page_with_curl: ASCII transliterations of Unicode text
http://twitter.com/FGRibreau
BSD 3-Clause "New" or "Revised" License
142 stars 20 forks source link

Using String#codePointAt()? #14

Open ashi009 opened 8 years ago

ashi009 commented 8 years ago

I noticed that the code converts utf8 to utf16 manually, however String#codePointAt() is already standardized for quite a while.

I think switch to use the built in version should give unidecode a huge performance boost.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36986931-using-string-codepointat?utm_campaign=plugin&utm_content=tracker%2F294213&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F294213&utm_medium=issues&utm_source=github).
FGRibreau commented 8 years ago

Hello @ashi009,

Indeed, I will accept a PR for it if the tests pass!