search

FGRibreau / ui-predicate

Finally a Predicate/Rule Editor UI component for the Web 🚀
https://ui-predicate.fgribreau.com/ui-predicate-vue/1.0.0/getting-started/
MIT License
159 stars 23 forks source link

Vue 3 support #152

Open andonov85 opened 2 years ago

andonov85 commented 2 years ago

Hello, François-Guillaume Ribreau and thank you for the great library!

We use the library in a project that we plan to migrate to Vue 3 and the question is whether support for Vue 3 is planned in the near future?

Thanks!

marclaporte commented 1 year ago

@FGRibreau What is complexity / level of work required here? Is this something a junior developer (in my team) could help with?

Thanks!

FGRibreau commented 1 year ago

Hello @marclaporte,

Since there is already an exemple facade for vue2, I think creating a facade for vue3 should not be a big deal yes :)

I will be able to guide him once a PR is open :)

marclaporte commented 1 year ago

@johnsantosDev Show us what you got :-)

johnsantosDev commented 1 year ago

Thanks @marclaporte, on it!

marclaporte commented 1 year ago

Change of plan (sorry)

@alvinBM is now in charge.

marclaporte commented 11 months ago

Closed as done! https://github.com/FGRibreau/ui-predicate/pull/192

Congrats @alvinBM and thank you to @FGRibreau

FGRibreau commented 11 months ago

@alvinBM @marclaporte @johnsantosDev Hello! Just a little update, I've indeed merged the PR but lots of things are not working (storybooks, tests, docs) on the vuejs3 package, I've started a refactor to make these parts rights and then I will create a new release.

Thanks a lot for your work!

marclaporte commented 5 months ago

@FGRibreau I am sending you positive thoughts on this topic :-)

FGRibreau commented 5 months ago

@marclaporte I'm deeply sorry Marc, I don't have the time right now to work on fixing all the missing things in this PR to make it mergeable in ui-predicate, maybe you have available developer bandwidth to do it (fix storybooks, tests & docs generation)?

(I can guide one of your dev asynchronously though!)

alvinBM commented 5 months ago

@marclaporte I'm deeply sorry Marc, I don't have the time right now to work on fixing all the missing things in this PR to make it mergeable in ui-predicate, maybe you have available developer bandwidth to do it (fix storybooks, tests & docs generation)?

(I can guide one of your dev asynchronously though!)

@FGRibreau , I am available to fix the various blocking points, so I'll always come back to you if necessary to move forward more quickly. THANKS

marclaporte commented 4 months ago

@FGRibreau Please re-open this task and assign to @alvinBM

FGRibreau commented 4 months ago

done @marclaporte !

alvinBM commented 4 months ago

Hello @FGRibreau,

I am in the process of fixing the problems related to the doc and the storybooks, but I am currently facing a lot of bugs and perhaps incompatibility especially with the storybooks.

I built the ui-predicate-vue3 package with vite 4.3.2 and vue 3.2.13, so I got a lot of errors related to parcelRequire used in ui-predicate-core.

I wonder if the current ui-predicate-core package is compatible with vite? Maybe you can have additional information that can help me move forward faster.

NB: For storybooks I use version 8.0.0

FGRibreau commented 4 months ago

I wonder if the current ui-predicate-core package is compatible with vite? Maybe you can have additional information that can help me move forward faster.

It might be indeed, it's a vanilla js library (using commonjs) that needs to be compiled for the browser so "any" builder will do :)

You can — of course — please update the current dependencies, I will release ui-predicate-core to a new major if I detect an interface change :)

On Mon, Mar 18, 2024 at 4:36 PM Alvin BAUMA @.***> wrote:

Hello @FGRibreau https://github.com/FGRibreau,

I am in the process of fixing the problems related to the doc and the storybooks, but I am currently facing a lot of bugs and perhaps incompatibility especially with the storybooks.

I built the ui-predicate-vue3 package with vite 4.3.2 and vue 3.2.13, so I got a lot of errors related to parcelRequire used in ui-predicate-core.

I wonder if the current ui-predicate-core package is compatible with vite? Maybe you can have additional information that can help me move forward faster.

NB: For storybooks I use version 8.0.0

— Reply to this email directly, view it on GitHub https://github.com/FGRibreau/ui-predicate/issues/152#issuecomment-2004238113, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBWQWTCFMWH35JTMSSZK3YY4CXNAVCNFSM5G2643Q2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQGQZDGOBRGEZQ . You are receiving this because you were mentioned.Message ID: @.***>

Yannick243 commented 2 months ago

Hello @FGRibreau,

Here is the PR that fixes the points mentioned below (fixes some bugs, updates Vue3 docs, and adds related Storybooks) https://github.com/FGRibreau/ui-predicate/pull/204

marclaporte commented 2 months ago

We can close via https://github.com/FGRibreau/ui-predicate/pull/204 and wait for a new version! 2.0.0?