search

FGasper / p5-Net-ACME2

CPAN’s Net::ACME2
Other
3 stars 7 forks source link

Fix a warning from Net::ACME2::Error::to_string #10

Closed atoomic closed 4 years ago

atoomic commented 4 years ago

Fixes GH #8

Smoke with the GitHub actions there https://github.com/atoomic/p5-Net-ACME2/actions/runs/47122296

FGasper commented 4 years ago

@atoomic Is it possible to know more about the ACME error objects that produced these warnings? Do you have repro steps?

If it’s as simple as an ACME server not sending status or type, then OK, but in all of my testing I’m pretty sure I didn’t see that.

(Not trying to be difficult, just want to be sure I understand the scope of the problem.)

FGasper commented 4 years ago

Based on https://tools.ietf.org/html/rfc7807#page-5, it appears that status is optional.

atoomic commented 4 years ago

@FGasper how does it look?