callback vs. promise syntax for generic (pre-adapter) query?

[jmandel]

Current README suggests something promise-like, i.e.

fhir.search('Patient', queryObject)
.then(function(bundle){...})

Should we rely on (or provide a base implementation of) promises, and then wrap those as (jquery/ng/whatever) framework-specific promises in adapters?

Or should we just provide a totally generic callback API in the base package, like

fhir.search('Patient', queryObject, onSuccess, onError);

I'm okay either way, but want to raise the question.

[niquola]

Looks like promises are idiomatic, but has many implementations.

If suggest that end user will use concrete library/framework api, internal fhir implementation could be generic - fhir.search('Patient', queryObject, onSuccess, onError).

As i know js community are trying to create specification

• https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Promise
• https://github.com/kriskowal/q
• http://wiki.commonjs.org/wiki/Promises/A
• https://github.com/promises-aplus/promises-spec

Too much details/questions, i personally like generic api and wrap them in promises on adapters :)

[jmandel]

Good. Callbacks it is.