search

FHIR / sushi

SUSHI (aka "SUSHI Unshortens Short Hand Inputs") is a reference implementation command-line interpreter/compiler for FHIR Shorthand (FSH).
Apache License 2.0
145 stars 44 forks source link

Fix problem with contentReference and Logic Models #1334

Closed bkaney closed 1 year ago

bkaney commented 1 year ago

When unfolding a contentReference, include fishing for Logical Models. This resolves https://github.com/FHIR/sushi/issues/1328

cmoesel commented 1 year ago

Thanks for this, @bkaney! I had this on my list for this sprint, but I'm glad you got to it first!

I would like a test for this, mainly to protect us against future changes that might break it again (however unlikely that may be). I was thinking just one simple test like this one, but w/ a logical model instead of a resource.

Since I was planning on implementing this anyway, I'm happy to accept your PR and then add a test after -- but I wanted to give you first dibs in case you want to add it as part of this PR.

bkaney commented 1 year ago

Hey @cmoesel -- I agree there should be a test! But I'm not sure what that test is doing at first glance,.. maybe it would be most efficient if you or someone on your team too a crack at it?

cmoesel commented 1 year ago

Sure thing. I'll take a crack at it and push back to your branch (if it lets me).

cmoesel commented 1 year ago

OK. It was a little more complicated than I originally thought. But I wrote two tests. I didn't have permission to push to your branch, so I made a PR into your PR branch here: https://github.com/Vermonster/sushi/pull/1

bkaney commented 1 year ago

@cmoesel -- okay, awesome your tests are part of this PR now!

cmoesel commented 1 year ago

Thanks, @bkaney. As per our usual approach, I'm going to wait until we have a 2nd review before merging. @jafeltra, can you take a look at this one?

bkaney commented 1 year ago

Thanks! the sql-on-fhir group really appreciates this moving forward!